Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add schema link for custom strong type connection #835

Merged
merged 11 commits into from
Oct 23, 2023
Merged

Add schema link for custom strong type connection #835

merged 11 commits into from
Oct 23, 2023

Conversation

chenslucky
Copy link
Contributor

@chenslucky chenslucky commented Oct 20, 2023 •
edited
Loading

Description

Add schema link for custom strong type connection.

vscode extension create connection test:
image

flow test with connection:
image

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@chenslucky chenslucky requested a review from a team as a code owner October 20, 2023 08:20
@chenslucky chenslucky temporarily deployed to internal October 20, 2023 08:20 — with GitHub Actions Inactive
@chenslucky chenslucky temporarily deployed to internal October 20, 2023 08:20 — with GitHub Actions Inactive
@chenslucky chenslucky temporarily deployed to internal October 20, 2023 08:20 — with GitHub Actions Inactive
@chenslucky chenslucky temporarily deployed to internal October 20, 2023 08:20 — with GitHub Actions Inactive
@chenslucky chenslucky temporarily deployed to internal October 20, 2023 08:20 — with GitHub Actions Inactive
@chenslucky chenslucky temporarily deployed to internal October 20, 2023 08:20 — with GitHub Actions Inactive
@chenslucky chenslucky temporarily deployed to internal October 20, 2023 08:20 — with GitHub Actions Inactive
@chenslucky chenslucky temporarily deployed to internal October 20, 2023 08:20 — with GitHub Actions Inactive
@chenslucky chenslucky temporarily deployed to internal October 20, 2023 08:20 — with GitHub Actions Inactive
@chenslucky chenslucky temporarily deployed to internal October 20, 2023 08:20 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Oct 20, 2023 •
edited
Loading

SDK CLI Global Config Test Result chesi/add-schema-url-for-strong-type

2 tests   2 ✔️  55s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit ac3d1f6.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 20, 2023 •
edited
Loading

Executor Unit Test Result chesi/add-schema-url-for-strong-type

    2 files      2 suites   2m 16s ⏱️
385 tests 385 ✔️ 0 💤 0 ❌
748 runs  747 ✔️ 1 💤 0 ❌

Results for commit ac3d1f6.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 20, 2023 •
edited
Loading

SDK PFS E2E Test Result chesi/add-schema-url-for-strong-type

8 tests   8 ✔️  33s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit ac3d1f6.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 20, 2023 •
edited
Loading

Executor E2E Test Result chesi/add-schema-url-for-strong-type

    2 files      2 suites   7m 19s ⏱️
104 tests 102 ✔️ 2 💤 0 ❌
208 runs  202 ✔️ 6 💤 0 ❌

Results for commit ac3d1f6.

♻️ This comment has been updated with latest results.

@chenslucky chenslucky temporarily deployed to internal October 20, 2023 08:37 — with GitHub Actions Inactive
@chenslucky chenslucky temporarily deployed to internal October 20, 2023 08:37 — with GitHub Actions Inactive
@chenslucky chenslucky temporarily deployed to internal October 20, 2023 08:37 — with GitHub Actions Inactive
@chenslucky chenslucky temporarily deployed to internal October 20, 2023 08:37 — with GitHub Actions Inactive
@chenslucky chenslucky temporarily deployed to internal October 20, 2023 08:37 — with GitHub Actions Inactive
@chenslucky chenslucky temporarily deployed to internal October 20, 2023 08:38 — with GitHub Actions Inactive
@chenslucky chenslucky temporarily deployed to internal October 20, 2023 08:38 — with GitHub Actions Inactive
@chenslucky chenslucky temporarily deployed to internal October 20, 2023 08:38 — with GitHub Actions Inactive
@chenslucky chenslucky temporarily deployed to internal October 20, 2023 08:38 — with GitHub Actions Inactive
@chenslucky chenslucky temporarily deployed to internal October 20, 2023 08:38 — with GitHub Actions Inactive
@chenslucky chenslucky temporarily deployed to internal October 23, 2023 01:34 — with GitHub Actions Inactive
@chenslucky chenslucky temporarily deployed to internal October 23, 2023 01:34 — with GitHub Actions Inactive
@chenslucky chenslucky temporarily deployed to internal October 23, 2023 01:39 — with GitHub Actions Inactive
@chenslucky chenslucky temporarily deployed to internal October 23, 2023 01:39 — with GitHub Actions Inactive
@chenslucky chenslucky temporarily deployed to internal October 23, 2023 01:39 — with GitHub Actions Inactive
@chenslucky chenslucky temporarily deployed to internal October 23, 2023 01:39 — with GitHub Actions Inactive
@chenslucky chenslucky temporarily deployed to internal October 23, 2023 01:39 — with GitHub Actions Inactive
@chenslucky chenslucky temporarily deployed to internal October 23, 2023 02:03 — with GitHub Actions Inactive
@chenslucky chenslucky temporarily deployed to internal October 23, 2023 02:03 — with GitHub Actions Inactive
@chenslucky chenslucky temporarily deployed to internal October 23, 2023 02:03 — with GitHub Actions Inactive
@chenslucky chenslucky temporarily deployed to internal October 23, 2023 02:03 — with GitHub Actions Inactive
@chenslucky chenslucky temporarily deployed to internal October 23, 2023 02:03 — with GitHub Actions Inactive
@chenslucky chenslucky temporarily deployed to internal October 23, 2023 02:07 — with GitHub Actions Inactive
@chenslucky chenslucky temporarily deployed to internal October 23, 2023 02:07 — with GitHub Actions Inactive
@chenslucky chenslucky temporarily deployed to internal October 23, 2023 02:07 — with GitHub Actions Inactive
@chenslucky chenslucky temporarily deployed to internal October 23, 2023 02:07 — with GitHub Actions Inactive
@chenslucky chenslucky temporarily deployed to internal October 23, 2023 02:07 — with GitHub Actions Inactive
@chenslucky chenslucky temporarily deployed to internal October 23, 2023 03:41 — with GitHub Actions Inactive
@chenslucky chenslucky temporarily deployed to internal October 23, 2023 03:44 — with GitHub Actions Inactive
@chenslucky chenslucky temporarily deployed to internal October 23, 2023 05:47 — with GitHub Actions Inactive
@chenslucky chenslucky temporarily deployed to internal October 23, 2023 06:13 — with GitHub Actions Inactive
@chenslucky chenslucky temporarily deployed to internal October 23, 2023 06:19 — with GitHub Actions Inactive
@chenslucky chenslucky merged commit 6df5507 into main Oct 23, 2023
31 checks passed
@chenslucky chenslucky deleted the chesi/add-schema-url-for-strong-type branch October 23, 2023 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dorisjoy dorisjoy dorisjoy approved these changes

@16oeahr 16oeahr 16oeahr approved these changes

Assignees
No one assigned
Labels
promptflow
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chenslucky @16oeahr @dorisjoy